IDE: Find and add workspace root if there are none #5285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the IDE is opened without a workspace (no folder is open), and then a Scala source is opened, we will now search for the closest possible workspace root (the closest parent directory that contains a `build.sbt`). If no such directory can be found, the parent directory of the file that has been opened is chosen. This folder is then added as a workspace folder. Adding a new workspace folder triggers a reloading of the extension. The code of the extension will be executed in an environment where a workspace root is set, and Dotty IDE will be able to start correctly. Fixes scala#5281
smarter
approved these changes
Oct 18, 2018
|
Good point, I verified and it works with the last commit 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the IDE is opened without a workspace (no folder is open), and then
a Scala source is opened, we will now search for the closest possible
workspace root (the closest parent directory that contains a
build.sbt). If no such directory can be found, the parent directory ofthe file that has been opened is chosen. This folder is then added as a
workspace folder.
Adding a new workspace folder triggers a reloading of the extension. The
code of the extension will be executed in an environment where a
workspace root is set, and Dotty IDE will be able to start correctly.
Fixes #5281